]> git.feebdaed.xyz Git - 0xmirror/ovs.git/commit
ovsdb: trigger: Silence dereference after null check warning.
authorEelco Chaudron <echaudro@redhat.com>
Mon, 1 Sep 2025 10:10:38 +0000 (12:10 +0200)
committerEelco Chaudron <echaudro@redhat.com>
Thu, 4 Sep 2025 06:40:57 +0000 (08:40 +0200)
commit3a5ea5f280188943a71e4b4eefc8d6446fd9d6c1
treec36cfbf4fdea06c078a8bbf0ef9d290349b11980
parent1856bfa4d629a9cde3cbcd114910824e23452963
ovsdb: trigger: Silence dereference after null check warning.

Coverity reported a possible null dereference of t->reply
when handling errors in the "committing" state for "transact" requests.

In practice, t->reply is always non-NULL at this point, but static analysis
cannot infer this guarantee. Adding ovs_assert(t->reply) documents the
invariant for developers and ensures debug builds will catch any misuse.

No change in runtime behavior; this only improves code safety and
satisfies static analysis.

Acked-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Mike Pattrick <mkp@redhat.com>
Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
ovsdb/trigger.c