]> git.feebdaed.xyz Git - 0xmirror/go.git/commit
runtime/secret: restore goroutine behavior to proposal
authorDaniel Morsing <daniel.morsing@gmail.com>
Wed, 10 Dec 2025 10:07:56 +0000 (10:07 +0000)
committerDavid Chase <drchase@google.com>
Fri, 12 Dec 2025 20:26:44 +0000 (12:26 -0800)
commit63fced531c0d702554fcfda41f9016701a6859c6
tree5475bb413e0f6bc9ea9aa417bf5e8ae173573fc9
parent6455afbc6f93e7ddc5ffde38b563c4e1a6821d22
runtime/secret: restore goroutine behavior to proposal

During review of CL 704615, a suggestion was made that spawning a
goroutine inside a call to secret.Do result in a panic. I agreed with
this at the time, but had missed that this had been extensively
discussed on the proposal. Revert the behavior back to what was agreed
upon.

Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842
Reviewed-on: https://go-review.googlesource.com/c/go/+/728920
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
src/runtime/proc.go
src/runtime/secret/secret.go