]> git.feebdaed.xyz Git - 0xmirror/go.git/commit
crypto: clean up subprocess-spawning tests
authorFilippo Valsorda <filippo@golang.org>
Tue, 9 Dec 2025 13:46:57 +0000 (14:46 +0100)
committerGopher Robot <gobot@golang.org>
Wed, 10 Dec 2025 21:46:04 +0000 (13:46 -0800)
commitfc66a5655be8ac334b92fb6dedc6aca5a0621681
treed4840e8b2b174245e1e7f3f9819ce6c519ca8f39
parentb130dab7927741223d40f221e27f3bd351e9cddf
crypto: clean up subprocess-spawning tests

Consistently use testenv.Command and testenv.Executable, avoid redundant
testenv.Must, use testenv.CleanCmdEnv where the output is parsed, always
log the output with a preceding newline, invoke tests with -v, and
always use cmd.Environ() to preserve existing env.

Change-Id: I647ff1a8b7d162e5e8df9424030fac446a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/728641
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
20 files changed:
src/crypto/cipher/gcm_fips140v2.0_test.go
src/crypto/cipher/gcm_test.go
src/crypto/ecdh/ecdh_test.go
src/crypto/fips140/enforcement_test.go
src/crypto/fips140/testdata/enforcement_test.go [deleted file]
src/crypto/internal/cryptotest/fetchmodule.go
src/crypto/internal/fips140deps/fipsdeps_test.go
src/crypto/internal/fips140test/acvp_test.go
src/crypto/internal/fips140test/cast_test.go
src/crypto/internal/fips140test/check_test.go
src/crypto/internal/sysrand/rand_linux_test.go
src/crypto/internal/sysrand/rand_test.go
src/crypto/purego_test.go
src/crypto/rand/rand_test.go
src/crypto/tls/bogo_shim_test.go
src/crypto/tls/link_test.go
src/crypto/x509/bettertls_test.go
src/crypto/x509/name_constraints_test.go
src/crypto/x509/root_linux_test.go
src/crypto/x509/x509_test.go