windows: Fix absolute-header.m4 for newer msys2 appearing as cygwin.

MSYS2 is trying to move closer to cygwin and as part of that effort
they changed reporting of the system triplets from msys to cygwin:
  https://www.msys2.org/news/#2025-06-20-replacing-x86_64-pc-msys-with-x86_64-pc-cygwin

This broke our builds in AppVeyor, since detection of absolute paths
for system headers is now using the wrong path separator list:

 checking absolute name of <stdio.h>... ""
 checking absolute name of <string.h>... ""

Fix by adding cygwin to the list for Windows-style paths.  With that,
we can properly detect the headers again:

 checking absolute name of <stdio.h>...
 "C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.22000.0\\ucrt\\stdio.h"
 checking absolute name of <string.h>...
 "C:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.22000.0\\ucrt\\string.h"

We used the 'Previous' variant of the image for AppVeyor before to
avoid this issue, but now even the previous image has the new MSYS2
and CI is fully broken without the fix.

Acked-by: Mike Pattrick <mkp@redhat.com>
Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

diff --git a/appveyor.yml b/appveyor.yml
index 77ec792e38d694f4e9d5faae9076ed5d988a0ea1..28a75c3afdf97072918e85a2908526a2c765d537 100644 (file)
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -1,5 +1,5 @@
 version: 1.0.{build}
-image: Previous Visual Studio 2019
+image: Visual Studio 2019
 branches:
   only:
   - main

diff --git a/m4/absolute-header.m4 b/m4/absolute-header.m4
index bdc12ff242caff233a71c82d0c9342db613da6b9..4c9fd0f74cbfa67e733692ef4eabb32f253b5397 100644 (file)
--- a/m4/absolute-header.m4
+++ b/m4/absolute-header.m4
@@ -68,7 +68,7 @@ AC_DEFUN([gl_ABSOLUTE_HEADER_ONE],
   esac
 changequote(,)
   case "$host_os" in
-    (mingw*|msys*)
+    (mingw*|msys*|cygwin*)
       dnl For the sake of native Windows compilers (excluding gcc),
       dnl treat backslash as a directory separator, like /.
       dnl Actually, these compilers use a double-backslash as