runtime/secret: restore goroutine behavior to proposal

During review of CL 704615, a suggestion was made that spawning a
goroutine inside a call to secret.Do result in a panic. I agreed with
this at the time, but had missed that this had been extensively
discussed on the proposal. Revert the behavior back to what was agreed
upon.

Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842
Reviewed-on: https://go-review.googlesource.com/c/go/+/728920
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>

diff --git a/src/runtime/proc.go b/src/runtime/proc.go
index 465a1adb601eca8d4b1e66c77607297bdbd4dc97..5ea96f03f5d125c8359478708b21e534d05d0580 100644 (file)
--- a/src/runtime/proc.go
+++ b/src/runtime/proc.go
@@ -5286,10 +5286,6 @@ func malg(stacksize int32) *g {
 // The compiler turns a go statement into a call to this.
 func newproc(fn *funcval) {
        gp := getg()
-       if goexperiment.RuntimeSecret && gp.secret > 0 {
-               panic("goroutine spawned while running in secret mode")
-       }
-
        pc := sys.GetCallerPC()
        systemstack(func() {
                newg := newproc1(fn, gp, pc, false, waitReasonZero)

diff --git a/src/runtime/secret/secret.go b/src/runtime/secret/secret.go
index f669b98828d0d16adae4bbdfb84f4c4e4dffe332..9eae22605fba0b1ee967b6307ee59f6bff4dd6b2 100644 (file)
--- a/src/runtime/secret/secret.go
+++ b/src/runtime/secret/secret.go
@@ -28,7 +28,7 @@ import (
 //   - Currently only supported on linux/amd64 and linux/arm64.  On unsupported
 //     platforms, Do will invoke f directly.
 //   - Protection does not extend to any global variables written by f.
-//   - Any attempt to launch a goroutine by f will result in a panic.
+//   - Protection does not extend to any new goroutines made by f.
 //   - If f calls runtime.Goexit, erasure can be delayed by defers
 //     higher up on the call stack.
 //   - Heap allocations will only be erased if the program drops all