[PH2][Warnings] Cleaning clang Warnings

PiperOrigin-RevId: 828361947

diff --git a/src/core/BUILD b/src/core/BUILD
index 83ce5120fcdfe98fd128d0de9a27c89540d1e9bc..1c0f74d32f0fed09d323a2f104f512d18916d111 100644 (file)
--- a/src/core/BUILD
+++ b/src/core/BUILD
@@ -8226,14 +8226,17 @@ grpc_cc_library(
         "absl/strings",
     ],
     deps = [
+        "activity",
         "channel_args",
         "channelz_property_list",
+        "context",
         "grpc_check",
         "http2_settings",
         "http2_settings_manager",
         "http2_status",
         "poll",
         "race",
+        "seq",
         "sleep",
         "time",
         "try_seq",
@@ -8374,6 +8377,7 @@ grpc_cc_library(
         "ext/transport/chttp2/transport/http2_client_transport.h",
     ],
     external_deps = [
+        "absl/base:core_headers",
         "absl/container:flat_hash_map",
         "absl/container:flat_hash_set",
         "absl/functional:any_invocable",
@@ -8411,6 +8415,7 @@ grpc_cc_library(
         "internal_channel_arg_names",
         "iomgr_fwd",
         "keepalive",
+        "latch",
         "latent_see",
         "loop",
         "map",

diff --git a/src/core/ext/transport/chttp2/transport/http2_settings_manager.cc b/src/core/ext/transport/chttp2/transport/http2_settings_manager.cc
index 03ad4e41b6c47c6d2872de011c6bc9101eeb7307..ae475028bf5693c3624c846a5cf07529ea0a1497 100644 (file)
--- a/src/core/ext/transport/chttp2/transport/http2_settings_manager.cc
+++ b/src/core/ext/transport/chttp2/transport/http2_settings_manager.cc
@@ -22,11 +22,11 @@
 
 #include <grpc/support/port_platform.h>
 
+#include <cstdint>
+#include <optional>
+
 #include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/ext/transport/chttp2/transport/http2_settings.h"
-#include "src/core/ext/transport/chttp2/transport/http2_status.h"
-#include "src/core/util/useful.h"
-#include "absl/strings/str_cat.h"
 
 namespace grpc_core {
 

diff --git a/src/core/ext/transport/chttp2/transport/http2_settings_manager.h b/src/core/ext/transport/chttp2/transport/http2_settings_manager.h
index d9127b40b73225fadf91c1929d2cf373c49a3ff8..f19b66b572fbb0f9b55609c307dff2fea46ac19e 100644 (file)
--- a/src/core/ext/transport/chttp2/transport/http2_settings_manager.h
+++ b/src/core/ext/transport/chttp2/transport/http2_settings_manager.h
@@ -22,15 +22,12 @@
 
 #include <cstdint>
 #include <optional>
-#include <queue>
+#include <vector>
 
 #include "src/core/channelz/property_list.h"
 #include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/ext/transport/chttp2/transport/http2_settings.h"
 #include "src/core/ext/transport/chttp2/transport/http2_status.h"
-#include "src/core/lib/channel/channel_args.h"
-#include "src/core/util/useful.h"
-#include "absl/functional/function_ref.h"
 #include "absl/strings/string_view.h"
 
 namespace grpc_core {

diff --git a/test/core/transport/chttp2/BUILD b/test/core/transport/chttp2/BUILD
index f6c74164f2f34de1c331bb2aa3139088475e00ff..e7a3bdd108c772abecdb766fc151607c890429b2 100644 (file)
--- a/test/core/transport/chttp2/BUILD
+++ b/test/core/transport/chttp2/BUILD
@@ -756,6 +756,7 @@ grpc_cc_test(
         "gtest",
     ],
     deps = [
+        "//:chttp2_frame",
         "//:gpr",
         "//:grpc",
         "//src/core:http2_settings",
@@ -848,6 +849,7 @@ grpc_cc_test(
     name = "http2_client_transport_test",
     srcs = ["http2_client_transport_test.cc"],
     external_deps = [
+        "absl/functional:any_invocable",
         "absl/log:check",
         "absl/log:log",
         "absl/status",
@@ -863,6 +865,7 @@ grpc_cc_test(
         "//:exec_ctx",
         "//:gpr",
         "//:grpc",
+        "//:grpc_transport_chttp2",
         "//:orphanable",
         "//src/core:arena",
         "//src/core:call_spine",
@@ -874,14 +877,20 @@ grpc_cc_test(
         "//src/core:http2_settings_manager",
         "//src/core:http2_status",
         "//src/core:http2_transport",
+        "//src/core:map",
         "//src/core:message",
         "//src/core:metadata",
+        "//src/core:metadata_batch",
         "//src/core:notification",
         "//src/core:poll",
         "//src/core:seq",
+        "//src/core:sleep",
+        "//src/core:slice",
+        "//src/core:slice_buffer",
         "//src/core:time",
         "//src/core:transport_common",
         "//src/core:try_join",
+        "//src/core:try_seq",
         "//test/core/promise:poll_matcher",
         "//test/core/test_util:grpc_test_util",
         "//test/core/test_util:grpc_test_util_base",
@@ -911,20 +920,27 @@ grpc_cc_test(
         "//:gpr",
         "//:grpc",
         "//:orphanable",
+        "//src/core:1999",
+        "//src/core:arena",
         "//src/core:call_spine",
         "//src/core:channel_args",
         "//src/core:default_event_engine",
         "//src/core:http2_client_transport",
         "//src/core:http2_settings",
         "//src/core:http2_settings_manager",
+        "//src/core:http2_settings_promises",
         "//src/core:http2_status",
         "//src/core:http2_transport",
+        "//src/core:map",
         "//src/core:message",
         "//src/core:metadata",
         "//src/core:notification",
+        "//src/core:poll",
+        "//src/core:sleep",
         "//src/core:time",
         "//src/core:transport_common",
         "//src/core:try_join",
+        "//src/core:try_seq",
         "//test/core/promise:poll_matcher",
         "//test/core/test_util:grpc_test_util",
         "//test/core/test_util:grpc_test_util_base",

diff --git a/test/core/transport/chttp2/http2_settings_test.cc b/test/core/transport/chttp2/http2_settings_test.cc
index 31e523234acffb64abe434001c3e2a93ddc6aee9..d72c2b5490ff86b4878f9d09c379936d7fc615f2 100644 (file)
--- a/test/core/transport/chttp2/http2_settings_test.cc
+++ b/test/core/transport/chttp2/http2_settings_test.cc
@@ -14,6 +14,12 @@
 
 #include "src/core/ext/transport/chttp2/transport/http2_settings.h"
 
+#include <cstdint>
+#include <optional>
+#include <utility>
+#include <vector>
+
+#include "src/core/ext/transport/chttp2/transport/frame.h"
 #include "src/core/ext/transport/chttp2/transport/http2_settings_manager.h"
 #include "gmock/gmock.h"
 #include "gtest/gtest.h"

diff --git a/test/core/transport/chttp2/settings_timeout_manager_test.cc b/test/core/transport/chttp2/settings_timeout_manager_test.cc
index 766001bd792bc7d7f8052584ed2bbf3491d6e9ec..54a9b05d295621ace0cd7d05de900e6b1ca9bfca 100644 (file)
--- a/test/core/transport/chttp2/settings_timeout_manager_test.cc
+++ b/test/core/transport/chttp2/settings_timeout_manager_test.cc
@@ -20,31 +20,25 @@
 #include <grpc/event_engine/slice.h>
 #include <grpc/grpc.h>
 
+#include <cstdint>
 #include <memory>
+#include <tuple>
 #include <utility>
 
-#include "src/core/call/call_spine.h"
-#include "src/core/config/core_configuration.h"
 #include "src/core/ext/transport/chttp2/transport/frame.h"
-#include "src/core/ext/transport/chttp2/transport/http2_client_transport.h"
-#include "src/core/ext/transport/chttp2/transport/http2_settings.h"
-#include "src/core/ext/transport/chttp2/transport/http2_settings_manager.h"
-#include "src/core/ext/transport/chttp2/transport/http2_status.h"
-#include "src/core/ext/transport/chttp2/transport/http2_transport.h"
-#include "src/core/ext/transport/chttp2/transport/transport_common.h"
+#include "src/core/ext/transport/chttp2/transport/http2_settings_promises.h"
 #include "src/core/lib/channel/channel_args.h"
 #include "src/core/lib/event_engine/default_event_engine.h"
 #include "src/core/lib/iomgr/exec_ctx.h"
+#include "src/core/lib/promise/party.h"
+#include "src/core/lib/promise/poll.h"
+#include "src/core/lib/promise/sleep.h"
 #include "src/core/lib/promise/try_join.h"
+#include "src/core/lib/promise/try_seq.h"
+#include "src/core/lib/resource_quota/arena.h"
 #include "src/core/util/notification.h"
 #include "src/core/util/orphanable.h"
 #include "src/core/util/time.h"
-#include "test/core/promise/poll_matcher.h"
-#include "test/core/test_util/postmortem.h"
-#include "test/core/transport/chttp2/http2_frame_test_helper.h"
-#include "test/core/transport/util/mock_promise_endpoint.h"
-#include "test/core/transport/util/transport_test.h"
-#include "gmock/gmock.h"
 #include "gtest/gtest.h"
 #include "absl/log/log.h"
 #include "absl/status/status.h"