checksrc: ban `strcpy`

No longer used in the codebase. Replacement is `curlx_strcopy()`, possibly
`memcpy()` or dynbuf.

Also:
- OS400: allow three calls.

Closes #20088

diff --git a/packages/OS400/os400sys.c b/packages/OS400/os400sys.c
index 04be163617a899854e33b86daa6cf64107a56b33..f3da1a4105a83809cd2e22c15e66ff69e2003f87 100644 (file)
--- a/packages/OS400/os400sys.c
+++ b/packages/OS400/os400sys.c
@@ -711,6 +711,7 @@ char *Curl_ldap_get_dn_a(void *ld, LDAPMessage *entry)
      ldap_memfree() and ldap_memalloc() does not exist. The solution is to
      overwrite the EBCDIC buffer with ASCII to return it. */
 
+  /* !checksrc! disable BANNEDFUNC 1 */
   strcpy(cp, cp2);
   free(cp2);
   return cp;
@@ -741,6 +742,7 @@ char *Curl_ldap_first_attribute_a(void *ld, LDAPMessage *entry,
      ldap_memfree() and ldap_memalloc() does not exist. The solution is to
      overwrite the EBCDIC buffer with ASCII to return it. */
 
+  /* !checksrc! disable BANNEDFUNC 1 */
   strcpy(cp, cp2);
   free(cp2);
   return cp;
@@ -771,6 +773,7 @@ char *Curl_ldap_next_attribute_a(void *ld, LDAPMessage *entry,
      ldap_memfree() and ldap_memalloc() does not exist. The solution is to
      overwrite the EBCDIC buffer with ASCII to return it. */
 
+  /* !checksrc! disable BANNEDFUNC 1 */
   strcpy(cp, cp2);
   free(cp2);
   return cp;

diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl
index 8839f38bf610a024d87d96238340af5b106e643c..cd5817a3828f6b0ac7f3f0e1c22d78254cb06d67 100755 (executable)
--- a/scripts/checksrc.pl
+++ b/scripts/checksrc.pl
@@ -110,6 +110,7 @@ my %banfunc = (
     "sscanf" => 1,
     "stat" => 1,
     "strcat" => 1,
+    "strcpy" => 1,
     "strdup" => 1,
     "strerror" => 1,
     "strncat" => 1,