[PH2][Experiment] Enable `sleep_use_non_owning_waker` (#41165)

 Enable `sleep_use_non_owning_waker`

Closes #41165

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/41165 from ac-patel:experiment1 d646a1d0c002fd2c85891adf6b83c0c2a2e554a9
PiperOrigin-RevId: 839219556

diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl
index 5454efb09e7bec88028ca4218e23f423cc121822..579a982860f49371d1f1f3efe134a401367e6a48 100644 (file)
--- a/bazel/experiments.bzl
+++ b/bazel/experiments.bzl
@@ -139,7 +139,6 @@ EXPERIMENTS = {
             ],
             "promise_test": [
                 "sleep_promise_exec_ctx_removal",
-                "sleep_use_non_owning_waker",
             ],
             "resource_quota_test": [
                 "free_large_allocator",
@@ -176,6 +175,9 @@ EXPERIMENTS = {
             "posix_endpoint_test": [
                 "event_engine_secure_endpoint",
             ],
+            "promise_test": [
+                "sleep_use_non_owning_waker",
+            ],
             "resolver_component_tests_runner_invoker": [
                 "event_engine_dns",
             ],
@@ -242,7 +244,6 @@ EXPERIMENTS = {
             ],
             "promise_test": [
                 "sleep_promise_exec_ctx_removal",
-                "sleep_use_non_owning_waker",
             ],
             "resource_quota_test": [
                 "free_large_allocator",
@@ -279,6 +280,9 @@ EXPERIMENTS = {
             "posix_endpoint_test": [
                 "event_engine_secure_endpoint",
             ],
+            "promise_test": [
+                "sleep_use_non_owning_waker",
+            ],
             "resolver_component_tests_runner_invoker": [
                 "event_engine_dns",
             ],
@@ -345,7 +349,6 @@ EXPERIMENTS = {
             ],
             "promise_test": [
                 "sleep_promise_exec_ctx_removal",
-                "sleep_use_non_owning_waker",
             ],
             "resource_quota_test": [
                 "free_large_allocator",
@@ -382,6 +385,9 @@ EXPERIMENTS = {
             "posix_endpoint_test": [
                 "event_engine_secure_endpoint",
             ],
+            "promise_test": [
+                "sleep_use_non_owning_waker",
+            ],
             "resolver_component_tests_runner_invoker": [
                 "event_engine_dns",
             ],

diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc
index 5218638016fd3fca149fc73a1783442babebe700..3b6eca83b786d1f5c846ffe9cb145bbe8b65cb8e 100644 (file)
--- a/src/core/lib/experiments/experiments.cc
+++ b/src/core/lib/experiments/experiments.cc
@@ -356,8 +356,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
      additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false,
      true},
     {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker,
-     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false,
-     true},
+     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true},
     {"subchannel_wrapper_cleanup_on_orphan",
      description_subchannel_wrapper_cleanup_on_orphan,
      additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0,
@@ -723,8 +722,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
      additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false,
      true},
     {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker,
-     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false,
-     true},
+     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true},
     {"subchannel_wrapper_cleanup_on_orphan",
      description_subchannel_wrapper_cleanup_on_orphan,
      additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0,
@@ -1090,8 +1088,7 @@ const ExperimentMetadata g_experiment_metadata[] = {
      additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false,
      true},
     {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker,
-     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false,
-     true},
+     additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true},
     {"subchannel_wrapper_cleanup_on_orphan",
      description_subchannel_wrapper_cleanup_on_orphan,
      additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0,

diff --git a/src/core/lib/experiments/experiments.h b/src/core/lib/experiments/experiments.h
index 0260b8413713321c092d71880f79bcb56f5160d0..4c8ac863455e41222bed9080e8b6cecbcc64a9a2 100644 (file)
--- a/src/core/lib/experiments/experiments.h
+++ b/src/core/lib/experiments/experiments.h
@@ -110,7 +110,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; }
 inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; }
 inline bool IsSkipClearPeerOnCancellationEnabled() { return false; }
 inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; }
-inline bool IsSleepUseNonOwningWakerEnabled() { return false; }
+#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER
+inline bool IsSleepUseNonOwningWakerEnabled() { return true; }
 inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; }
 inline bool IsTcpFrameSizeTuningEnabled() { return false; }
 inline bool IsTcpRcvLowatEnabled() { return false; }
@@ -174,7 +175,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; }
 inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; }
 inline bool IsSkipClearPeerOnCancellationEnabled() { return false; }
 inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; }
-inline bool IsSleepUseNonOwningWakerEnabled() { return false; }
+#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER
+inline bool IsSleepUseNonOwningWakerEnabled() { return true; }
 inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; }
 inline bool IsTcpFrameSizeTuningEnabled() { return false; }
 inline bool IsTcpRcvLowatEnabled() { return false; }
@@ -238,7 +240,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; }
 inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; }
 inline bool IsSkipClearPeerOnCancellationEnabled() { return false; }
 inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; }
-inline bool IsSleepUseNonOwningWakerEnabled() { return false; }
+#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER
+inline bool IsSleepUseNonOwningWakerEnabled() { return true; }
 inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; }
 inline bool IsTcpFrameSizeTuningEnabled() { return false; }
 inline bool IsTcpRcvLowatEnabled() { return false; }

diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml
index 4504034c299b398110a5c570f6c186c15ad4e831..e3b0e8f3eeff7d45936dd7318d0b1cf62debe1d6 100644 (file)
--- a/src/core/lib/experiments/rollouts.yaml
+++ b/src/core/lib/experiments/rollouts.yaml
@@ -95,7 +95,7 @@
 - name: sleep_promise_exec_ctx_removal
   default: false
 - name: sleep_use_non_owning_waker
-  default: false
+  default: true
 - name: tcp_frame_size_tuning
   default: false
 - name: tcp_rcv_lowat