From: ac-patel Date: Tue, 2 Dec 2025 13:18:21 +0000 (-0800) Subject: [PH2][Experiment] Enable `sleep_use_non_owning_waker` (#41165) X-Git-Url: https://git.feebdaed.xyz/?a=commitdiff_plain;h=bbe29bb9989d6ef79c526b02cc53fc61ea35a49d;p=0xmirror%2Fgrpc.git [PH2][Experiment] Enable `sleep_use_non_owning_waker` (#41165) Enable `sleep_use_non_owning_waker` Closes #41165 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/41165 from ac-patel:experiment1 d646a1d0c002fd2c85891adf6b83c0c2a2e554a9 PiperOrigin-RevId: 839219556 --- diff --git a/bazel/experiments.bzl b/bazel/experiments.bzl index 5454efb09e..579a982860 100644 --- a/bazel/experiments.bzl +++ b/bazel/experiments.bzl @@ -139,7 +139,6 @@ EXPERIMENTS = { ], "promise_test": [ "sleep_promise_exec_ctx_removal", - "sleep_use_non_owning_waker", ], "resource_quota_test": [ "free_large_allocator", @@ -176,6 +175,9 @@ EXPERIMENTS = { "posix_endpoint_test": [ "event_engine_secure_endpoint", ], + "promise_test": [ + "sleep_use_non_owning_waker", + ], "resolver_component_tests_runner_invoker": [ "event_engine_dns", ], @@ -242,7 +244,6 @@ EXPERIMENTS = { ], "promise_test": [ "sleep_promise_exec_ctx_removal", - "sleep_use_non_owning_waker", ], "resource_quota_test": [ "free_large_allocator", @@ -279,6 +280,9 @@ EXPERIMENTS = { "posix_endpoint_test": [ "event_engine_secure_endpoint", ], + "promise_test": [ + "sleep_use_non_owning_waker", + ], "resolver_component_tests_runner_invoker": [ "event_engine_dns", ], @@ -345,7 +349,6 @@ EXPERIMENTS = { ], "promise_test": [ "sleep_promise_exec_ctx_removal", - "sleep_use_non_owning_waker", ], "resource_quota_test": [ "free_large_allocator", @@ -382,6 +385,9 @@ EXPERIMENTS = { "posix_endpoint_test": [ "event_engine_secure_endpoint", ], + "promise_test": [ + "sleep_use_non_owning_waker", + ], "resolver_component_tests_runner_invoker": [ "event_engine_dns", ], diff --git a/src/core/lib/experiments/experiments.cc b/src/core/lib/experiments/experiments.cc index 5218638016..3b6eca83b7 100644 --- a/src/core/lib/experiments/experiments.cc +++ b/src/core/lib/experiments/experiments.cc @@ -356,8 +356,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false, true}, {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker, - additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false, - true}, + additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true}, {"subchannel_wrapper_cleanup_on_orphan", description_subchannel_wrapper_cleanup_on_orphan, additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0, @@ -723,8 +722,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false, true}, {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker, - additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false, - true}, + additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true}, {"subchannel_wrapper_cleanup_on_orphan", description_subchannel_wrapper_cleanup_on_orphan, additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0, @@ -1090,8 +1088,7 @@ const ExperimentMetadata g_experiment_metadata[] = { additional_constraints_sleep_promise_exec_ctx_removal, nullptr, 0, false, true}, {"sleep_use_non_owning_waker", description_sleep_use_non_owning_waker, - additional_constraints_sleep_use_non_owning_waker, nullptr, 0, false, - true}, + additional_constraints_sleep_use_non_owning_waker, nullptr, 0, true, true}, {"subchannel_wrapper_cleanup_on_orphan", description_subchannel_wrapper_cleanup_on_orphan, additional_constraints_subchannel_wrapper_cleanup_on_orphan, nullptr, 0, diff --git a/src/core/lib/experiments/experiments.h b/src/core/lib/experiments/experiments.h index 0260b84137..4c8ac86345 100644 --- a/src/core/lib/experiments/experiments.h +++ b/src/core/lib/experiments/experiments.h @@ -110,7 +110,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; } inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; } inline bool IsSkipClearPeerOnCancellationEnabled() { return false; } inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; } -inline bool IsSleepUseNonOwningWakerEnabled() { return false; } +#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER +inline bool IsSleepUseNonOwningWakerEnabled() { return true; } inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; } inline bool IsTcpFrameSizeTuningEnabled() { return false; } inline bool IsTcpRcvLowatEnabled() { return false; } @@ -174,7 +175,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; } inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; } inline bool IsSkipClearPeerOnCancellationEnabled() { return false; } inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; } -inline bool IsSleepUseNonOwningWakerEnabled() { return false; } +#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER +inline bool IsSleepUseNonOwningWakerEnabled() { return true; } inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; } inline bool IsTcpFrameSizeTuningEnabled() { return false; } inline bool IsTcpRcvLowatEnabled() { return false; } @@ -238,7 +240,8 @@ inline bool IsSecureEndpointOffloadLargeReadsEnabled() { return false; } inline bool IsSecureEndpointOffloadLargeWritesEnabled() { return false; } inline bool IsSkipClearPeerOnCancellationEnabled() { return false; } inline bool IsSleepPromiseExecCtxRemovalEnabled() { return false; } -inline bool IsSleepUseNonOwningWakerEnabled() { return false; } +#define GRPC_EXPERIMENT_IS_INCLUDED_SLEEP_USE_NON_OWNING_WAKER +inline bool IsSleepUseNonOwningWakerEnabled() { return true; } inline bool IsSubchannelWrapperCleanupOnOrphanEnabled() { return false; } inline bool IsTcpFrameSizeTuningEnabled() { return false; } inline bool IsTcpRcvLowatEnabled() { return false; } diff --git a/src/core/lib/experiments/rollouts.yaml b/src/core/lib/experiments/rollouts.yaml index 4504034c29..e3b0e8f3ee 100644 --- a/src/core/lib/experiments/rollouts.yaml +++ b/src/core/lib/experiments/rollouts.yaml @@ -95,7 +95,7 @@ - name: sleep_promise_exec_ctx_removal default: false - name: sleep_use_non_owning_waker - default: false + default: true - name: tcp_frame_size_tuning default: false - name: tcp_rcv_lowat