systemd service - don't use deprecated PermissionsStartOnly (#6465)

Bump codespell-project/actions-codespell from 2.1 to 2.2 in the github-actions-dependencies group (#6466)

Bump codespell-project/actions-codespell

Bumps the github-actions-dependencies group with 1 update: [codespell-project/actions-codespell](https://github.com/codespell-project/actions-codespell).

Updates `codespell-project/actions-codespell` from 2.1 to 2.2
- [Release notes](https://github.com/codespell-project/actions-codespell/releases)
- [Commits](https://github.com/codespell-project/actions-codespell/compare/406322ec52dd7b488e48c1c4b82e2a8b3a1bf630...8f01853be192eb0f849a5c7d721450e7a467c579)

---
updated-dependencies:
- dependency-name: codespell-project/actions-codespell
  dependency-version: '2.2'
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

systemd service - don't use deprecated PermissionsStartOnly

- elevate Prestart and Poststop script permissions using "+" prefix instead,
as per https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Command%20lines

( PermissionsStartOnly was deprecated in systemd 241 and no longer appears in
documentation since 2018 https://github.com/systemd/systemd/pull/10802 )

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

Fix libcap capabilities not being granted on OpenRC distros (#6456)

Fix libcap capabilities not being granted on OpenRC distros

Created on behalf of @mgziminsky - see this issue comment: https://github.com/pi-hole/pi-hole/issues/6454#issuecomment-3476576177

Signed-off-by: Sparronator9999 <86388887+Sparronator9999@users.noreply.github.com>

Add Fedora 43 to test suite (#6453)

Bump github/codeql-action from 4.31.0 to 4.31.2 in the github-actions-dependencies group (#6455)

Bump github/codeql-action in the github-actions-dependencies group

Bumps the github-actions-dependencies group with 1 update: [github/codeql-action](https://github.com/github/codeql-action).

Updates `github/codeql-action` from 4.31.0 to 4.31.2
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/4e94bd11f71e507f7f87df81788dff88d1dacbfb...0499de31b99561a6d14a36a5f662c2a54f91beee)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Add Fedora 43 to test suite

Signed-off-by: yubiuser <github@yubiuser.dev>

Sync master back into development (#6448)

v6.2.2 (#6447)

Bump github/codeql-action from 4.30.9 to 4.31.0 in the github-actions-dependencies group across 1 directory (#6446)

Bump github/codeql-action

Bumps the github-actions-dependencies group with 1 update in the / directory: [github/codeql-action](https://github.com/github/codeql-action).

Updates `github/codeql-action` from 4.30.9 to 4.31.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/16140ae1a102900babc80a33c44059580f687047...4e94bd11f71e507f7f87df81788dff88d1dacbfb)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Start using commented tags for editorconfig-checker (#6443)

Add bind9-dnsutils as dependency for APT based systems (#6444)

Add log file path variables and ensure log files are created if missing (#6441)

Create version file, if not existing (on first Container start) (#6440)

Add bind9-dnsutils as dependency for APT based systems

Signed-off-by: Christian König <github@yubiuser.dev>

Bump tox from 4.31.0 to 4.32.0 in /test in the python-dependencies group (#6433)

Start using commented tags for editorconfig-checker

Signed-off-by: Christian König <github@yubiuser.dev>

Add log file path variables and ensure log files are created if missing

Signed-off-by: Yannick7777 <admin@eyer.life>

Ensure 'versions' file exist on first start

Signed-off-by: casperklein <casperklein@users.noreply.github.com>

Sync master back into development (#6434)

Fix formatting in chooseInterface function (#6435)

Fix formatting in chooseInterface function to ensure proper variable expansion - with quotes, the dialog command throws the error:

Expected at least 20 tokens for --radi, have 5.
Use --help to list options.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Pi-hole Core v6.2 (#6411)

Bump tox from 4.31.0 to 4.32.0 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.31.0 to 4.32.0
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.31.0...4.32.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.32.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix gravity indention (#6427)

Apply suggestion from @rdwebdesign

Co-authored-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: yubiuser <github@yubiuser.dev>

Bump the github-actions-dependencies group with 2 updates (#6426)

Fix gravity indention

Signed-off-by: Christian König <github@yubiuser.dev>

Bump the github-actions-dependencies group with 2 updates

Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker).

Updates `github/codeql-action` from 4.30.8 to 4.30.9
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/f443b600d91635bebf5b0d9ebc620189c0d6fba5...16140ae1a102900babc80a33c44059580f687047)

Updates `editorconfig-checker/action-editorconfig-checker` from 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases)
- [Commits](https://github.com/editorconfig-checker/action-editorconfig-checker/compare/1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4...5ecdd656fe347c26f76b1b435b90e1d74fb5e787)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-actions-dependencies
- dependency-name: editorconfig-checker/action-editorconfig-checker
  dependency-version: 5ecdd656fe347c26f76b1b435b90e1d74fb5e787
  dependency-type: direct:production
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Tiny change to make `prev2` also a local variable (#6420)

add missing local variable

Signed-off-by: casperklein <casperklein@users.noreply.github.com>

Bump tox from 4.30.3 to 4.31.0 in /test in the python-dependencies group (#6418)

Bump the github-actions-dependencies group with 2 updates (#6417)

Bump tox from 4.30.3 to 4.31.0 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.30.3 to 4.31.0
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.30.3...4.31.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.31.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump the github-actions-dependencies group with 2 updates

Bumps the github-actions-dependencies group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker).

Updates `github/codeql-action` from 3.30.6 to 4.30.8
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/64d10c13136e1c5bce3e5fbde8d4906eeaafc885...f443b600d91635bebf5b0d9ebc620189c0d6fba5)

Updates `editorconfig-checker/action-editorconfig-checker` from f40bac9e7d9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases)
- [Commits](https://github.com/editorconfig-checker/action-editorconfig-checker/compare/f40bac9e7d9e7d298fbe36b83e1eff8f0de13fb8...1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.8
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
- dependency-name: editorconfig-checker/action-editorconfig-checker
  dependency-version: 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4
  dependency-type: direct:production
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Rename views, upgrade gravity database and bump gravity databae version (#6386)

Bump the python-dependencies group across 1 directory with 3 updates (#6407)

Bump the github-actions-dependencies group across 1 directory with 4 updates (#6409)

Bump the github-actions-dependencies group across 1 directory with 4 updates

Bumps the github-actions-dependencies group with 4 updates in the / directory: [github/codeql-action](https://github.com/github/codeql-action), [actions/stale](https://github.com/actions/stale), [psf/black](https://github.com/psf/black) and [actions/setup-python](https://github.com/actions/setup-python).

Updates `github/codeql-action` from 3.29.10 to 3.30.6
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/96f518a34f7a870018057716cc4d7a5c014bd61c...64d10c13136e1c5bce3e5fbde8d4906eeaafc885)

Updates `actions/stale` from 9.1.0 to 10.1.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/5bef64f19d7facfb25b37b414482c7164d639639...5f858e3efba33a5ca4407a664cc011ad407f2008)

Updates `psf/black` from 25.1.0 to 25.9.0
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/compare/8a737e727ac5ab2f1d4cf5876720ed276dc8dc4b...af0ba72a73598c76189d6dd1b21d8532255d5942)

Updates `actions/setup-python` from 5.6.0 to 6.0.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/a26af69be951a213d495a4c3e4e4022e16d87065...e797f83bcb11b83ae66e0230d6156d7c80228e7c)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.30.6
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
- dependency-name: actions/stale
  dependency-version: 10.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
- dependency-name: psf/black
  dependency-version: 25.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: github-actions-dependencies
- dependency-name: actions/setup-python
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Use SHA to pin github actions (#6392)

Use sha also fpr editor-config-checker without adding a specific tag commit

Signed-off-by: Christian König <github@yubiuser.dev>

Bump the python-dependencies group across 1 directory with 3 updates

Bumps the python-dependencies group with 3 updates in the /test directory: [pyyaml](https://github.com/yaml/pyyaml), [pytest](https://github.com/pytest-dev/pytest) and [tox](https://github.com/tox-dev/tox).

Updates `pyyaml` from 6.0.2 to 6.0.3
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/6.0.3/CHANGES)
- [Commits](https://github.com/yaml/pyyaml/compare/6.0.2...6.0.3)

Updates `pytest` from 8.4.1 to 8.4.2
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/8.4.1...8.4.2)

Updates `tox` from 4.28.4 to 4.30.2
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.28.4...4.30.2)

---
updated-dependencies:
- dependency-name: pyyaml
  dependency-version: 6.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-dependencies
- dependency-name: pytest
  dependency-version: 8.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-dependencies
- dependency-name: tox
  dependency-version: 4.30.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Adjust .shellcheckrc to 0.11 and enable some optional checks (#6374)

Add Debian 13 Trixie to the test suite (#6382)

Fix typo found during install (#6406)

Fix typo found during install

Signed-off-by: Jon Herron <jon.herron@yahoo.com>

uninstall refactor and improvement (#6339)

Uninstall refactor

Split removePiholeFiles into functions for each category.

Reorder execution so that:
  Pihole-FTL is stopped and removed before shutdown scripts are removed.
  User and group are removed before needed commands are removed.

Remove database and log files in user-specified non-default locations,
and use local directories from basic install.sh, falling back to defaults.

Remove use of sudo as the script already checks that it is called as root.

Advise user of location of crontab backup if is created

Make use of service control functions, command detection and default
directories from basic_install.sh

Align variable names with current basic-install.sh

Disable pihole-FTL service immediately, if systemctl is available

Call systemd daemon-reload after removing service files (on systemd systems)

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

Alpine Linux Support and Tests (#6275)

Use SHA to pin github actions

Signed-off-by: Christian König <github@yubiuser.dev>

Don't use hard-coded path for pihole user `nologin` shell

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Alpine: Switch cron service from busybox to cronie during install

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Alpine: Ensure community repo is enabled and handle dependency install errors

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Alpine: Add some additional dependencies and minor script fixes

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Alpine Linux tests

Add Dockerfile and corresponding tox file to add alpine linux 3.21 & 3.22 to the test suite
Add apk as another package manager in the automated install tests
Use short switches for su command as busybox's su does not accept long switches here
Add Alpine test to github workflow

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Add support for alpine

Signed-off-by: Michael Ziminsky (Z) <mgziminsky@users.noreply.github.com>

Add FTL bash autocomplete (#6376)

Bump actions/checkout from 4.2.2 to 5.0.0 in the github-actions-dependencies group (#6387)

Bump actions/checkout in the github-actions-dependencies group

Bumps the github-actions-dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout).

Updates `actions/checkout` from 4.2.2 to 5.0.0
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4.2.2...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Rename views, upgrade gravity database and bump gravity databae version

Signed-off-by: DL6ER <dl6er@dl6er.de>

Add Debian 13 Trixie to the test suite

Signed-off-by: Christian König <github@yubiuser.dev>

Fix shellcheck warnings

Signed-off-by: Christian König <github@yubiuser.dev>

Use pihole-FTL --complete to generate autocomplete suggestions

Signed-off-by: Christian König <github@yubiuser.dev>

Fix shellcheck warnings for pihole bash completion

Signed-off-by: Christian König <github@yubiuser.dev>

Add pihole-FTL bash completion

Signed-off-by: Christian König <github@yubiuser.dev>

Adjust .shellcheckrc to 0.11 and enable some optional checks

Signed-off-by: Christian König <github@yubiuser.dev>

Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group (#6371)

Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.28.3 to 4.28.4
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.28.3...4.28.4)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.28.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Add "setpassword" to pihole Bash completion (#6369)

Add "setpassword" to pihole Bash completion

Its missing.
After:

```
$ sudo pihole
allow          arpflush       disable        logging        reloadlists    tail           version
allow-regex    checkout       enable         query          repair         uninstall      wildcard
allow-wild     debug          flush          regex          setpassword    updateGravity
api            deny           help           reloaddns      status         updatePihole
```

Signed-off-by: deHakkelaar <deHakkelaar@users.noreply.github.com>

Explicitly check for the existence of FTL binary before attempting to stop it. Prevents warning message on fresh installs (#6364)

Do not call pihole-FTL --config interactively (#6368)

Use non-interactive shell in utils.sh:getFTLConfigValue to avoid colored output

Signed-off-by: DL6ER <dl6er@dl6er.de>

Revert "pihole api - use keepalive for curl queries" (#6367)

Revert "pihole api - use keepalive for curl queries"

Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group (#6366)

Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.27.0 to 4.28.3
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.27.0...4.28.3)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.28.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Update automated install/basic-install.sh

Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: Adam Warner <github@adamwarner.co.uk>

Check for the existence of the FTL binary before stopping the service
This prevents errors on fresh installs where the FTL binary does not exist yet.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

pihole api - use keepalive for curl queries (#6365)

pihole api - use keepalive for curl queries

Adds the keepalive header to all curl requests

This reduces session establishment time across the multiple

requests necessary to authenticate, obtain response and log out

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

Use 'true'/'false' strings instead of 0/1 integers for boolean root user check in pihole command (#6351)

Group functions

Signed-off-by: Christian König <github@yubiuser.dev>

Invert need_root logic and check if set/unset

Signed-off-by: Christian König <github@yubiuser.dev>
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>

Fix gravity user permission checking and fix error on pihole-FTL --config failures (#6352)

Separate network flush and arp table flush functions (#6319)

This PR updates the function flushing the network tables and the ARP table. It separates the two, renaming the whole function to networkflush and makes flushing ARP optional by appending --arp. Deletion of the network table is now done via FTL's /action/flush/arp endpoint.

Documentation: https://github.com/pi-hole/docs/pull/1253
Related PR in the FTL repo: https://github.com/pi-hole/FTL/pull/2541

Group evaluations

Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>
Signed-off-by: yubiuser <github@yubiuser.dev>

Improve setFTLConfigValue function

Signed-off-by: Christian König <github@yubiuser.dev>

Revert https://github.com/pi-hole/pi-hole/pull/6345

Signed-off-by: Christian König <github@yubiuser.dev>

Tweak fluash ARP function

Signed-off-by: Christian König <github@yubiuser.dev>

Update man page - remove "reconfigure" option (#6361)

Update man page - remove "reconfigure" option

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Speed up `pihole api` (#6336)

Use RTMIN value provided by FTL when possible (#6358)

In some cases `kill -RTMIN` can send incorrect signal value to the FTL causing it to terminate instead of performing lists reload.
https://github.com/pi-hole/FTL/issues/2573

Reduce pihole --query jq calls (#6334)

Re-order authentication errors in verbose mode (#6338)