Bump actions/checkout in the github-actions-dependencies group

Bumps the github-actions-dependencies group with 1 update: [actions/checkout](https://github.com/actions/checkout).

Updates `actions/checkout` from 4.2.2 to 5.0.0
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v4.2.2...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-actions-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group (#6371)

Bump tox from 4.28.3 to 4.28.4 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.28.3 to 4.28.4
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.28.3...4.28.4)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.28.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Add "setpassword" to pihole Bash completion (#6369)

Add "setpassword" to pihole Bash completion

Its missing.
After:

```
$ sudo pihole
allow          arpflush       disable        logging        reloadlists    tail           version
allow-regex    checkout       enable         query          repair         uninstall      wildcard
allow-wild     debug          flush          regex          setpassword    updateGravity
api            deny           help           reloaddns      status         updatePihole
```

Signed-off-by: deHakkelaar <deHakkelaar@users.noreply.github.com>

Explicitly check for the existence of FTL binary before attempting to stop it. Prevents warning message on fresh installs (#6364)

Do not call pihole-FTL --config interactively (#6368)

Use non-interactive shell in utils.sh:getFTLConfigValue to avoid colored output

Signed-off-by: DL6ER <dl6er@dl6er.de>

Revert "pihole api - use keepalive for curl queries" (#6367)

Revert "pihole api - use keepalive for curl queries"

Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group (#6366)

Bump tox from 4.27.0 to 4.28.3 in /test in the python-dependencies group

Bumps the python-dependencies group in /test with 1 update: [tox](https://github.com/tox-dev/tox).

Updates `tox` from 4.27.0 to 4.28.3
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.27.0...4.28.3)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.28.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: python-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>

Update automated install/basic-install.sh

Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: Adam Warner <github@adamwarner.co.uk>

Check for the existence of the FTL binary before stopping the service
This prevents errors on fresh installs where the FTL binary does not exist yet.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

pihole api - use keepalive for curl queries (#6365)

pihole api - use keepalive for curl queries

Adds the keepalive header to all curl requests

This reduces session establishment time across the multiple

requests necessary to authenticate, obtain response and log out

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

Use 'true'/'false' strings instead of 0/1 integers for boolean root user check in pihole command (#6351)

Group functions

Signed-off-by: Christian König <github@yubiuser.dev>

Invert need_root logic and check if set/unset

Signed-off-by: Christian König <github@yubiuser.dev>
Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>

Fix gravity user permission checking and fix error on pihole-FTL --config failures (#6352)

Separate network flush and arp table flush functions (#6319)

This PR updates the function flushing the network tables and the ARP table. It separates the two, renaming the whole function to networkflush and makes flushing ARP optional by appending --arp. Deletion of the network table is now done via FTL's /action/flush/arp endpoint.

Documentation: https://github.com/pi-hole/docs/pull/1253
Related PR in the FTL repo: https://github.com/pi-hole/FTL/pull/2541

Group evaluations

Co-authored-by: Dan Schaper <dan.schaper@pi-hole.net>
Signed-off-by: yubiuser <github@yubiuser.dev>

Improve setFTLConfigValue function

Signed-off-by: Christian König <github@yubiuser.dev>

Revert https://github.com/pi-hole/pi-hole/pull/6345

Signed-off-by: Christian König <github@yubiuser.dev>

Tweak fluash ARP function

Signed-off-by: Christian König <github@yubiuser.dev>

Update man page - remove "reconfigure" option (#6361)

Update man page - remove "reconfigure" option

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Speed up `pihole api` (#6336)

Use RTMIN value provided by FTL when possible (#6358)

In some cases `kill -RTMIN` can send incorrect signal value to the FTL causing it to terminate instead of performing lists reload.
https://github.com/pi-hole/FTL/issues/2573

Reduce pihole --query jq calls (#6334)

Re-order authentication errors in verbose mode (#6338)

Remove netcat from the list of dependencies (#6343)

Use RTMIN value provided by FTL when possible

Signed-off-by: Jack'lul <jacklulcat@gmail.com>

Revert https://github.com/pi-hole/pi-hole/pull/6312

Signed-off-by: Christian König <github@yubiuser.dev>

Remove `readonly` from list.sh to avoid errors (#6349)

Remove `readonly` from list.sh to avoid errors

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Sync master back into development (#6348)

Pi-hole core 6.1.4 (#6347)

Fix `pihole api` command by not setting the some variabes as readonly (#6346)

Fix issue where web interface cannot run gravity (#6345)

bare minimum first past fix for `pihoe api` command not working due to attempting to re-set readony variabes PI_HOE_SCRIPT_DIR and utisfie.

Can't compain about them being readony if they're.. not.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Allow non-root access for updateGravity command

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Sync master back into development (#6341)

Remove netcat from the list of dependencies

Signed-off-by: darkexplosiveqwx <101737077+darkexplosiveqwx@users.noreply.github.com>

Pi-hole Core v6.1.3 (#6337)

Re-order authentication errors in verbose mode

Signed-off-by: Christian König <github@yubiuser.dev>

Speed up pihole --api

Get session authentication information via single jq operation,
setting defaults if no data returned.

Simplify jq test for valid JSON data

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

basic-install.sh listing interfaces (#6269)

Update basic-install.sh

Added comments

Update advanced/Scripts/query.sh

Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: Rob Gill <rrobgill@protonmail.com>

speed up pihole --query

Count list and gravity matches using jq in a single step.

Use jq's map to simplify list processing, eliminating intermediate
jsons.

Eliminate while loop for each lists's final output and formatting.

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

piholeDebug - Get default route robustly (#6303)

Sync master back into development (#6332)

Update release.yml

Signed-off-by: Adam Warner <me@adamwarner.co.uk>

Update Firewalld tests to match v6 ports (#6307)

update: abort if FTL branch does not exist (#6329)

update: abort if FTL branch does not exist

Currently, if the FTL update check returns 404, hence the FTL branch does not seem to exist, an error message is printed, but the update continues, only the FTL update is skipped.

This can lead to setups with v5 FTL and v6 core/web, failing at config migration, where FTL is invoked with a v6-only command.

With this change, the update aborts immediately if the FTL branch is invalid, like it does in case of other FTL update check errors (other HTTP error codes than 404 or other curl errors). Hence it continues only if FTL is up-to-date already, or a new version from the given branch has been found.

Signed-off-by: MichaIng <micha@dietpi.com>

Do not skip root check for pihole user (#6312)

Prevent gravity curl from using unset bash variable's empty string. (#6191)

Only update the package cache on fresh installations (#6282)

installer: exit if FTL update check fails (#6316)

Fix pihole -q by setting PI_HOLE_SCRIPT_DIR in api.sh (#6284)

Update python version used in test to 3.13 (#6321)

Bump pytest-xdist from 3.7.0 to 3.8.0 in /test (#6324)

Bump pytest-xdist from 3.7.0 to 3.8.0 in /test

Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases)
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.7.0...v3.8.0)

---
updated-dependencies:
- dependency-name: pytest-xdist
  dependency-version: 3.8.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Update python version used in test to 3.13

Signed-off-by: Christian König <github@yubiuser.dev>

taillog Prevent grep interpeting search term as an option (#6318)

taillog Prevent grep interpeting search term as an option

Adds '--' indicating end of options before the user provided
search pattern.

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

installer: exit if FTL update check fails

The return code of `FTLdetect()` is used in the installer to know whether FTL has been installed or not.

The function however returns an error only, if the download of FTL fails, not if checking for a latest version/update of FTL fails. This way, installs and rapairs can continue without or with ourdated FTL until `pihole-FTL migrate v6`, which hangs endlessly, if it is a v5 FTL.

This commit handles the return code in `FTLdetect()`, and lets it return true only if FTL download succeeded, or if the update check succeeded and FTL is up-to-date. Else, it could neither be repaired, nor installed, and the error message should give a hint what went wrong, hence exit.

`FTLdetect()` is not called by any other script, hence this change has no surprising effect elsewhere.

Additionally, a syntax error in the `FTLcheckUpdate()` function itself is fixed, which masks the `check_download_exists()` return code, hence always leads to error code 4, if the FTL branch is not `master`.

Signed-off-by: MichaIng <micha@dietpi.com>

piholeDebug - Get default route robustly

    Determine address and interface of default route by preceeding
    'via' and 'dev' fields in json output instead of plain text
    field position.

    Log if unable to determine default gateway

Signed-off-by: Rob Gill <rrobgill@protonmail.com>

Clean COL_TABLE and allow to send color codes when invoked by FTL (`${FORCE_COLOR}`) (#6314)

Set color codes when FORCE_COLOR is true

Signed-off-by: Christian König <github@yubiuser.dev>

Remove deprecated and unused colors

Signed-off-by: Christian König <github@yubiuser.dev>

Fix dependabot (#6297)

Add note about adding local user to pihole group to final dialog  (#6152)

Do not skipp root check for pihole user

Signed-off-by: Christian König <github@yubiuser.dev>

Bump pytest from 8.4.0 to 8.4.1 in /test (#6311)

Bump tox from 4.26.0 to 4.27.0 in /test (#6310)

Bump pytest from 8.4.0 to 8.4.1 in /test

Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.4.0 to 8.4.1.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/8.4.0...8.4.1)

---
updated-dependencies:
- dependency-name: pytest
  dependency-version: 8.4.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tox from 4.26.0 to 4.27.0 in /test

Bumps [tox](https://github.com/tox-dev/tox) from 4.26.0 to 4.27.0.
- [Release notes](https://github.com/tox-dev/tox/releases)
- [Changelog](https://github.com/tox-dev/tox/blob/main/docs/changelog.rst)
- [Commits](https://github.com/tox-dev/tox/compare/4.26.0...4.27.0)

---
updated-dependencies:
- dependency-name: tox
  dependency-version: 4.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Add HTTPS and NTP services to firewalld test

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Remove test for port 4711

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>

Fix dependabot

Signed-off-by: Christian König <github@yubiuser.dev>

Run package update everytime before building the meta package when invoking from the install script

Signed-off-by: Christian König <github@yubiuser.dev>

Separate package manager detection and cache update functions

Signed-off-by: Christian König <github@yubiuser.dev>

Add 'never-stale' to the exempt issue labels of the stale workflow (#6283)

Dependabot: group updates (#6294)

Dependabot: group updates

Signed-off-by: XhmikosR <xhmikosr@gmail.com>

Bump pytest-xdist from 3.6.1 to 3.7.0 in /test (#6254)

Bump pytest-xdist from 3.6.1 to 3.7.0 in /test

Bumps [pytest-xdist](https://github.com/pytest-dev/pytest-xdist) from 3.6.1 to 3.7.0.
- [Release notes](https://github.com/pytest-dev/pytest-xdist/releases)
- [Changelog](https://github.com/pytest-dev/pytest-xdist/blob/master/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest-xdist/compare/v3.6.1...v3.7.0)

---
updated-dependencies:
- dependency-name: pytest-xdist
  dependency-version: 3.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump pytest from 8.3.5 to 8.4.0 in /test (#6293)

Bump pytest from 8.3.5 to 8.4.0 in /test

Bumps [pytest](https://github.com/pytest-dev/pytest) from 8.3.5 to 8.4.0.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pytest-dev/pytest/compare/8.3.5...8.4.0)

---
updated-dependencies:
- dependency-name: pytest
  dependency-version: 8.4.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Sync master back into development (#6291)

Set PI_HOLE_SCRIPT_DIR in api.sh

Signed-off-by: Christian König <github@yubiuser.dev>

Add 'never-stale' to the exempt issue labels of the stale workflow

Signed-off-by: Christian König <github@yubiuser.dev>

We test a fresh installaton, so don't pretend this is not a fresh installation

Signed-off-by: Christian König <github@yubiuser.dev>

Only update the package cache on fresh installations

Signed-off-by: Christian König <github@yubiuser.dev>

basic-install.sh listing interfaces

Following up on below one:

https://github.com/pi-hole/pi-hole/pull/6236

And below poor attempt:

https://github.com/pi-hole/pi-hole/pull/6256

Signed-off-by: deHakkelaar <deHakkelaar@users.noreply.github.com>

Pi-hole Core v6.1.1 (#6267)

Revert "Use PID1 to determine which command to use when toggeling services" (#6262)